| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250124220516.113798-8-gerhard@engleder-embedded.com>
Date: Fri, 24 Jan 2025 23:05:16 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: andrew@...n.ch,
hkallweit1@...il.com,
linux@...linux.org.uk,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com
Cc: netdev@...r.kernel.org,
Gerhard Engleder <gerhard@...leder-embedded.com>
Subject: [RFC PATCH net-next v3 7/7] tsnep: Add PHY loopback selftests
Add loopback selftests on PHY level. This enables quick testing of
loopback functionality to ensure working loopback for testing.
Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
---
drivers/net/ethernet/engleder/Kconfig | 1 +
.../net/ethernet/engleder/tsnep_selftests.c | 153 +++++++++++++++++-
2 files changed, 150 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/engleder/Kconfig b/drivers/net/ethernet/engleder/Kconfig
index 3df6bf476ae7..8245a9c4377d 100644
--- a/drivers/net/ethernet/engleder/Kconfig
+++ b/drivers/net/ethernet/engleder/Kconfig
@@ -32,6 +32,7 @@ config TSNEP_SELFTESTS
bool "TSN endpoint self test support"
default n
depends on TSNEP
+ imply NET_SELFTESTS
help
This enables self test support within the TSN endpoint driver.
diff --git a/drivers/net/ethernet/engleder/tsnep_selftests.c b/drivers/net/ethernet/engleder/tsnep_selftests.c
index 8a9145f93147..c9857e5a8033 100644
--- a/drivers/net/ethernet/engleder/tsnep_selftests.c
+++ b/drivers/net/ethernet/engleder/tsnep_selftests.c
@@ -4,12 +4,15 @@
#include "tsnep.h"
#include <net/pkt_sched.h>
+#include <net/selftests.h>
enum tsnep_test {
TSNEP_TEST_ENABLE = 0,
TSNEP_TEST_TAPRIO,
TSNEP_TEST_TAPRIO_CHANGE,
TSNEP_TEST_TAPRIO_EXTENSION,
+ TSNEP_TEST_PHY_1000_LOOPBACK,
+ TSNEP_TEST_PHY_100_LOOPBACK,
};
static const char tsnep_test_strings[][ETH_GSTRING_LEN] = {
@@ -17,6 +20,8 @@ static const char tsnep_test_strings[][ETH_GSTRING_LEN] = {
"TAPRIO (offline)",
"TAPRIO change (offline)",
"TAPRIO extension (offline)",
+ "PHY 1000Mbps loopback (offline)",
+ "PHY 100Mbps loopback (offline)",
};
#define TSNEP_TEST_COUNT (sizeof(tsnep_test_strings) / ETH_GSTRING_LEN)
@@ -754,6 +759,133 @@ static bool tsnep_test_taprio_extension(struct tsnep_adapter *adapter)
return false;
}
+static bool test_loopback(struct tsnep_adapter *adapter, int speed)
+{
+ struct phy_device *phydev = adapter->phydev;
+ int retval;
+
+ retval = phy_loopback(phydev, true, speed);
+ if (retval || !phydev->loopback_enabled || !phydev->link ||
+ phydev->speed != speed)
+ return false;
+
+ retval = net_test_phy_loopback_udp(adapter->netdev);
+ if (retval)
+ return false;
+
+ retval = net_test_phy_loopback_udp_mtu(adapter->netdev);
+ if (retval)
+ return false;
+
+ retval = net_test_phy_loopback_tcp(adapter->netdev);
+ if (retval)
+ return false;
+
+ retval = phy_loopback(phydev, false, 0);
+ if (retval || phydev->loopback_enabled)
+ return false;
+
+ return true;
+}
+
+static bool set_speed(struct tsnep_adapter *adapter, int speed)
+{
+ struct ethtool_link_ksettings cmd;
+ int retval;
+
+ retval = tsnep_ethtool_ops.get_link_ksettings(adapter->netdev, &cmd);
+ if (retval)
+ return false;
+
+ if (speed) {
+ cmd.base.speed = speed;
+ cmd.base.duplex = DUPLEX_FULL;
+ cmd.base.autoneg = AUTONEG_DISABLE;
+ } else {
+ cmd.base.autoneg = AUTONEG_ENABLE;
+ }
+
+ retval = tsnep_ethtool_ops.set_link_ksettings(adapter->netdev, &cmd);
+ if (retval)
+ return false;
+
+ return true;
+}
+
+static bool tsnep_test_phy_1000_loopback(struct tsnep_adapter *adapter)
+{
+ if (!adapter->netdev->phydev)
+ return false;
+
+ if (!test_loopback(adapter, 1000))
+ goto failed;
+
+ /* after autonegotiation */
+ if (!set_speed(adapter, 0))
+ goto failed;
+ if (!test_loopback(adapter, 1000))
+ goto failed;
+
+ /* after 100Mbps fixed speed */
+ if (!set_speed(adapter, 100))
+ goto failed;
+ if (!test_loopback(adapter, 1000))
+ goto failed;
+
+ /* after 1000Mbps fixed speed */
+ if (!set_speed(adapter, 1000))
+ goto failed;
+ if (!test_loopback(adapter, 1000))
+ goto failed;
+
+ if (!set_speed(adapter, 0))
+ goto failed;
+
+ return true;
+
+failed:
+ phy_loopback(adapter->phydev, false, 0);
+ set_speed(adapter, 0);
+ return false;
+}
+
+static bool tsnep_test_phy_100_loopback(struct tsnep_adapter *adapter)
+{
+ if (!adapter->netdev->phydev)
+ return false;
+
+ if (!test_loopback(adapter, 100))
+ goto failed;
+
+ /* after autonegotiation */
+ if (!set_speed(adapter, 0))
+ goto failed;
+ if (!test_loopback(adapter, 100))
+ goto failed;
+
+ /* 100Mbps fixed speed */
+ if (!set_speed(adapter, 100))
+ goto failed;
+ if (!test_loopback(adapter, 100))
+ goto failed;
+
+ /* 1000Mbps fixed speed */
+ if (!set_speed(adapter, 1000))
+ goto failed;
+ if (!test_loopback(adapter, 100))
+ goto failed;
+
+ if (!set_speed(adapter, 0))
+ goto failed;
+
+ return true;
+
+failed:
+ phy_loopback(adapter->phydev, false, 0);
+ set_speed(adapter, 0);
+ return false;
+}
+
int tsnep_ethtool_get_test_count(void)
{
return TSNEP_TEST_COUNT;
@@ -768,15 +900,14 @@ void tsnep_ethtool_self_test(struct net_device *netdev,
struct ethtool_test *eth_test, u64 *data)
{
struct tsnep_adapter *adapter = netdev_priv(netdev);
+ int i;
eth_test->len = TSNEP_TEST_COUNT;
if (eth_test->flags != ETH_TEST_FL_OFFLINE) {
/* no tests are done online */
- data[TSNEP_TEST_ENABLE] = 0;
- data[TSNEP_TEST_TAPRIO] = 0;
- data[TSNEP_TEST_TAPRIO_CHANGE] = 0;
- data[TSNEP_TEST_TAPRIO_EXTENSION] = 0;
+ for (i = 0; i < TSNEP_TEST_COUNT; i++)
+ data[i] = 0;
return;
}
@@ -808,4 +939,18 @@ void tsnep_ethtool_self_test(struct net_device *netdev,
eth_test->flags |= ETH_TEST_FL_FAILED;
data[TSNEP_TEST_TAPRIO_EXTENSION] = 1;
}
+
+ if (tsnep_test_phy_1000_loopback(adapter)) {
+ data[TSNEP_TEST_PHY_1000_LOOPBACK] = 0;
+ } else {
+ eth_test->flags |= ETH_TEST_FL_FAILED;
+ data[TSNEP_TEST_PHY_1000_LOOPBACK] = 1;
+ }
+
+ if (tsnep_test_phy_100_loopback(adapter)) {
+ data[TSNEP_TEST_PHY_100_LOOPBACK] = 0;
+ } else {
+ eth_test->flags |= ETH_TEST_FL_FAILED;
+ data[TSNEP_TEST_PHY_100_LOOPBACK] = 1;
+ }
}
--
2.39.5
Powered by blists - more mailing lists