netdev - Re: [PATCH net-next 1/1] selftests: net: Add support for testing SO_RCVMARK and SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <679b95838f17_1c77632944f@willemb.c.googlers.com.notmuch>
Date: Thu, 30 Jan 2025 10:06:43 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 Anna Emese Nyiri <annaemesenyiri@...il.com>
Cc: netdev@...r.kernel.org, 
 fejes@....elte.hu, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 willemb@...gle.com, 
 idosch@...sch.org, 
 davem@...emloft.net, 
 horms@...nel.org, 
 shuah@...nel.org, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] selftests: net: Add support for testing
 SO_RCVMARK and SO_RCVPRIORITY

Jakub Kicinski wrote:
> On Wed, 29 Jan 2025 15:36:01 +0100 Anna Emese Nyiri wrote:
> > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> > index 73ee88d6b043..98f05473e672 100644
> > --- a/tools/testing/selftests/net/Makefile
> > +++ b/tools/testing/selftests/net/Makefile
> > @@ -33,6 +33,7 @@ TEST_PROGS += gro.sh
> >  TEST_PROGS += gre_gso.sh
> >  TEST_PROGS += cmsg_so_mark.sh
> >  TEST_PROGS += cmsg_so_priority.sh
> > +TEST_PROGS += test_so_rcv.sh
> 
> You need to add the C part to the TEST_GEN_PROGS, otherwise it won't
> get built. We're seeing:

and to .gitignore
 
> ./test_so_rcv.sh: line 25: ./so_rcv_listener: No such file or directory
> 
> in the CI.
> 
> > +	memset(&recv_addr, 0, sizeof(recv_addr));
> > +	recv_addr.sin_family = AF_INET;
> > +	recv_addr.sin_port = htons(atoi(opt.service));
> > +
> > +	if (inet_pton(AF_INET, opt.host, &recv_addr.sin_addr) <= 0) {
> > +		perror("Invalid address");
> > +		ret_value = -errno;
> > +		goto cleanup;
> > +	}
> 
> Any reason not to use getaddrinfo() ?
> 
> Otherwise LGTM, thanks for following up!
> -- 
> pw-bot: cr