netdev - Re: [PATCH net v2 2/2] net: ipv6: fix dst ref loops in rpl, seg6 and ioam6 lwtunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59f99151-b1ca-456f-9e87-85dcac5db797@uliege.be>
Date: Thu, 30 Jan 2025 16:12:23 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
 netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, dsahern@...nel.org
Subject: Re: [PATCH net v2 2/2] net: ipv6: fix dst ref loops in rpl, seg6 and
 ioam6 lwtunnels



On 1/30/25 15:55, Jakub Kicinski wrote:
> On Thu, 30 Jan 2025 14:52:14 +0100 Justin Iurman wrote:
>>> On 1/30/25 4:15 AM, Jakub Kicinski wrote:
>>>> Some lwtunnels have a dst cache for post-transformation dst.
>>>> If the packet destination did not change we may end up recording
>>>> a reference to the lwtunnel in its own cache, and the lwtunnel
>>>> state will never be freed.
>>>
>>> The series LGTM, but I'm wondering if we can't have a similar loop for
>>> input lwt?
>>
>> Hmmm, I think Paolo is right. At least, I don't see a reason why it
>> wouldn't be correct. We should also take care of input lwt for both
>> seg6_iptunnel and rpl_iptunnel (ioam6_iptunnel does not implement input).
> 
> Would you be able to take care of that?

Sure, I'll send a patch as soon as this patchset is merged to net.

> And perhaps add a selftest at least for the looped cases?

ioam6.sh already triggers the looped cases in both inline and encap 
tests. Not sure about seg6 though, and there is no selftest for rpl.