lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CH3PR11MB8313FC7A7EA90AF5C257DD4FEAE82@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Fri, 31 Jan 2025 00:24:53 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "xudu@...hat.com"
	<xudu@...hat.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Simon
 Horman" <horms@...nel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Maxwell, Jon" <jmaxwell@...hat.com>, "Karlsson, Magnus"
	<magnus.karlsson@...el.com>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>,
	"Nagraj, Shravan" <shravan.nagraj@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v5 iwl-net 3/3] ice: stop storing XDP
 verdict within ice_rx_buf



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Thursday, January 23, 2025 8:31 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
>netdev@...r.kernel.org; xudu@...hat.com; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Kitszel,
>Przemyslaw <przemyslaw.kitszel@...el.com>; Keller, Jacob E
><jacob.e.keller@...el.com>; Maxwell, Jon <jmaxwell@...hat.com>; Karlsson,
>Magnus <magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH v5 iwl-net 3/3] ice: stop storing XDP verdict
>within ice_rx_buf
>
>Idea behind having ice_rx_buf::act was to simplify and speed up the Rx data
>path by walking through buffers that were representing cleaned HW Rx
>descriptors. Since it caused us a major headache recently and we rolled back to
>old approach that 'puts' Rx buffers right after running XDP prog/creating skb,
>this is useless now and should be removed.
>
>Get rid of ice_rx_buf::act and related logic. We still need to take care of a corner
>case where XDP program releases a particular fragment.
>
>Make ice_run_xdp() to return its result and use it within ice_put_rx_mbuf().
>
>Fixes: 2fba7dc5157b ("ice: Add support for XDP multi-buffer on Rx side")
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Reviewed-by: Simon Horman <horms@...nel.org>
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_txrx.c     | 62 +++++++++++--------
> drivers/net/ethernet/intel/ice/ice_txrx.h     |  1 -
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 43 -------------
> 3 files changed, 36 insertions(+), 70 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ