netdev - RE: [Intel-wired-lan] [PATCH v5 iwl-net 1/3] ice: put Rx buffers after being done with current frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH3PR11MB8313DC9AE85F7B2AF4AB20F1EAE82@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Fri, 31 Jan 2025 00:27:57 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "xudu@...hat.com"
	<xudu@...hat.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Simon
 Horman" <horms@...nel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Maxwell, Jon" <jmaxwell@...hat.com>, "Karlsson, Magnus"
	<magnus.karlsson@...el.com>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Nagraj, Shravan"
	<shravan.nagraj@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v5 iwl-net 1/3] ice: put Rx buffers
 after being done with current frame



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Thursday, January 23, 2025 8:31 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
>netdev@...r.kernel.org; xudu@...hat.com; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Kitszel,
>Przemyslaw <przemyslaw.kitszel@...el.com>; Keller, Jacob E
><jacob.e.keller@...el.com>; Maxwell, Jon <jmaxwell@...hat.com>; Karlsson,
>Magnus <magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH v5 iwl-net 1/3] ice: put Rx buffers after being
>done with current frame
>
>Introduce a new helper ice_put_rx_mbuf() that will go through gathered frags
>from current frame and will call ice_put_rx_buf() on them. Current logic that
>was supposed to simplify and optimize the driver where we go through a batch
>of all buffers processed in current NAPI instance turned out to be broken for
>jumbo frames and very heavy load that was coming from both multi-thread
>iperf and nginx/wrk pair between server and client. The delay introduced by
>approach that we are dropping is simply too big and we need to take the
>decision regarding page recycling/releasing as quick as we can.
>
>While at it, address an error path of ice_add_xdp_frag() - we were missing
>buffer putting from day 1 there.
>
>As a nice side effect we get rid of annoying and repetitive three-liner:
>
>	xdp->data = NULL;
>	rx_ring->first_desc = ntc;
>	rx_ring->nr_frags = 0;
>
>by embedding it within introduced routine.
>
>Fixes: 1dc1a7e7f410 ("ice: Centrallize Rx buffer recycling")
>Reported-and-tested-by: Xu Du <xudu@...hat.com>
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Reviewed-by: Simon Horman <horms@...nel.org>
>Co-developed-by: Jacob Keller <jacob.e.keller@...el.com>
>Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 79 ++++++++++++++---------
> 1 file changed, 50 insertions(+), 29 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)