netdev - Re: [PATCH] net: dsa: sja1105: Use of_get_available_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e4243f2-4186-4b97-b39f-3c3dad4a444b@lunn.ch>
Date: Sat, 1 Feb 2025 19:38:26 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH] net: dsa: sja1105: Use of_get_available_child_by_name()

On Sat, Feb 01, 2025 at 04:49:57PM +0000, Biju Das wrote:
> Use the helper of_get_available_child_by_name() to simplify
> sja1105_mdiobus_register().
> 
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
> This patch is only compile tested and depend upon[1]
> [1] https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renesas.com/
> ---
>  drivers/net/dsa/sja1105/sja1105_mdio.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/dsa/sja1105/sja1105_mdio.c b/drivers/net/dsa/sja1105/sja1105_mdio.c
> index 84b7169f2974..d73bf5c9525b 100644
> --- a/drivers/net/dsa/sja1105/sja1105_mdio.c
> +++ b/drivers/net/dsa/sja1105/sja1105_mdio.c
> @@ -461,24 +461,21 @@ int sja1105_mdiobus_register(struct dsa_switch *ds)
>  	struct sja1105_private *priv = ds->priv;
>  	const struct sja1105_regs *regs = priv->info->regs;
>  	struct device_node *switch_node = ds->dev->of_node;
> -	struct device_node *mdio_node;
> +	struct device_node *mdio_node _free(device_node) =
> +		of_get_available_child_by_name(switch_node, "mdios");

There is a dislike within netdev for this magical _free() thing, made
worse by it not actually calling kfree() as the name would
suggest. Pleased explicitly put the node.

    Andrew

---
pw-bot: cr