netdev - RE: [PATCH] net: dsa: sja1105: Use of_get_available_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113464D39FC1809AC112ABD6D86EA2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sun, 2 Feb 2025 10:13:58 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
	biju.das.au <biju.das.au@...il.com>
Subject: RE: [PATCH] net: dsa: sja1105: Use of_get_available_child_by_name()

Hi Andrew,

Thanks for the feedback.

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 01 February 2025 18:38
> Subject: Re: [PATCH] net: dsa: sja1105: Use of_get_available_child_by_name()
> 
> On Sat, Feb 01, 2025 at 04:49:57PM +0000, Biju Das wrote:
> > Use the helper of_get_available_child_by_name() to simplify
> > sja1105_mdiobus_register().
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > This patch is only compile tested and depend upon[1] [1]
> > https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renes
> > as.com/
> > ---
> >  drivers/net/dsa/sja1105/sja1105_mdio.c | 15 ++++-----------
> >  1 file changed, 4 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/net/dsa/sja1105/sja1105_mdio.c
> > b/drivers/net/dsa/sja1105/sja1105_mdio.c
> > index 84b7169f2974..d73bf5c9525b 100644
> > --- a/drivers/net/dsa/sja1105/sja1105_mdio.c
> > +++ b/drivers/net/dsa/sja1105/sja1105_mdio.c
> > @@ -461,24 +461,21 @@ int sja1105_mdiobus_register(struct dsa_switch *ds)
> >  	struct sja1105_private *priv = ds->priv;
> >  	const struct sja1105_regs *regs = priv->info->regs;
> >  	struct device_node *switch_node = ds->dev->of_node;
> > -	struct device_node *mdio_node;
> > +	struct device_node *mdio_node _free(device_node) =
> > +		of_get_available_child_by_name(switch_node, "mdios");
> 
> There is a dislike within netdev for this magical _free() thing, made worse by it not actually calling
> kfree() as the name would suggest. Pleased explicitly put the node.

Thanks. I was not aware of this. I will send next version with readable code once
dependency patch hits on net-next.

Cheers,
Biju