netdev - Re: Move airoha in a dedicated folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+_ehUwFTa2VvfqeTPyedFDWBHj3PeUem=ASMrrh1h3++yLc_A@mail.gmail.com>
Date: Sun, 2 Feb 2025 16:50:33 +0100
From: "Christian Marangi (Ansuel)" <ansuelsmth@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	nbd@....name, sean.wang@...iatek.com, upstream@...oha.com
Subject: Re: Move airoha in a dedicated folder

Il giorno sab 1 feb 2025 alle ore 16:50 Simon Horman
<horms@...nel.org> ha scritto:
>
> On Sat, Feb 01, 2025 at 01:44:53PM +0100, Lorenzo Bianconi wrote:
> > Hi all,
> >
> > Since more features are on the way for airoha_eth driver (support for flowtable
> > hw offloading, 10g phy support, ..), I was wondering if it is neater to move
> > the driver in a dedicated folder (e.g. drivers/net/ethernet/airoha or
> > drivers/net/ethernet/mediatek/airoha) or if you prefer to keep current
> > approach. Thanks.
>
> <2c>
>
> Hi Lorenzo,
>
> There already seem drivers to be drivers under drivers/net/ethernet/mediatek/
> which are built from more than once .c file. So I think it is fine
> to leave Airoha's source there. But, OTOH, I do think it would
> be neater to move it into it's own directory. Which is to say,
> I for one am happy either way.
>
> If you do chose to go for a new directory, I would suggest
> drivers/net/ethernet/mediatek/airoha assuming as it is a Mediatek device.
>

Hi,
may I push for a dedicated Airoha directory? (/net/ethernet/airoha ?)

With new SoC it seems Airoha is progressively detaching from Mediatek.

There are some similarities but for example for the PPE only the logical entry
table is similar but rest of the stuff is handled by a coprocessor
with dedicated
firmware. My big concern is that we will start to bloat the mediatek directory
with very different kind of code.

Putting stuff in ethernet/mediatek/airoha would imply starting to use
format like
#include "../stuff.h" and maybe we would start to import stuff from
mediatek that
should not be used by airoha.

Keeping the 2 thing split might make the similarities even more
evident and easier
to handle as we will have to rework the header to use the generic include/linux.

Hope all of this makes sense, it's really to prevent situation and keep things
organized from the start.