netdev - Re: Move airoha in a dedicated folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634c90a1-e671-42ae-9751-fee3a599af20@lunn.ch>
Date: Sun, 2 Feb 2025 17:49:49 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Christian Marangi (Ansuel)" <ansuelsmth@...il.com>
Cc: Simon Horman <horms@...nel.org>, Lorenzo Bianconi <lorenzo@...nel.org>,
	netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	nbd@....name, sean.wang@...iatek.com, upstream@...oha.com
Subject: Re: Move airoha in a dedicated folder

> Hi,
> may I push for a dedicated Airoha directory? (/net/ethernet/airoha ?)
> 
> With new SoC it seems Airoha is progressively detaching from Mediatek.

The vendor name is actually not very relevant. Linux has a much longer
life than most vendors. Assets get bought and sold, but they keep the
same name in Linux simply to make Maintenance simpler. FEC has not
been part of Freescale for a long time. Microsemi and micrel are part
of microchip, but we still call them microsemi and micrel, because who
knows, microchip might soon be eaten by somebody bigger, or broken up?

> Putting stuff in ethernet/mediatek/airoha would imply starting to
> use format like #include "../stuff.h" and maybe we would start to
> import stuff from mediatek that should not be used by airoha.

obj-$(CONFIG_NET_AIROHA) += airoha_eth.o

#include <linux/etherdevice.h>
#include <linux/iopoll.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
#include <linux/of.h>
#include <linux/of_net.h>
#include <linux/platform_device.h>
#include <linux/reset.h>
#include <linux/tcp.h>
#include <linux/u64_stats_sync.h>
#include <net/dsa.h>
#include <net/page_pool/helpers.h>
#include <net/pkt_cls.h>
#include <uapi/linux/ppp_defs.h>

I don't see anything being shared. Maybe that is just because those
features are not implemented yet? But if there is sharing, we do want
code to be shared, rather than copy/paste bugs and code between
drivers.

Maybe drivers/net/ethernet/wangxun is a good model to follow, although
i might put the headers in include/linux/net/mediatek rather than do
relative #includes.

	Andrew