netdev - Re: [PATCH v2 bpf] net: Add rx_skb of kfree_skb to raw_tp_null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173858823421.3242491.5873739358513954554.git-patchwork-notify@kernel.org>
Date: Mon, 03 Feb 2025 13:10:34 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: martin.lau@...ux.dev, ast@...nel.org, daniel@...earbox.net,
 andrii@...nel.org, memxor@...il.com, kuni1840@...il.com, bpf@...r.kernel.org,
 netdev@...r.kernel.org, yan@...udflare.com
Subject: Re: [PATCH v2 bpf] net: Add rx_skb of kfree_skb to raw_tp_null_args[].

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Fri, 31 Jan 2025 19:01:42 -0800 you wrote:
> Yan Zhai reported a BPF prog could trigger a null-ptr-deref [0]
> in trace_kfree_skb if the prog does not check if rx_sk is NULL.
> 
> Commit c53795d48ee8 ("net: add rx_sk to trace_kfree_skb") added
> rx_sk to trace_kfree_skb, but rx_sk is optional and could be NULL.
> 
> Let's add kfree_skb to raw_tp_null_args[] to let the BPF verifier
> validate such a prog and prevent the issue.
> 
> [...]

Here is the summary with links:
  - [v2,bpf] net: Add rx_skb of kfree_skb to raw_tp_null_args[].
    https://git.kernel.org/bpf/bpf/c/fc610c8c586c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html