netdev - Re: [PATCH v2 bpf] net: Add rx_skb of kfree_skb to raw_tp_null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6o8GKce9xSDlAC2@krava>
Date: Mon, 10 Feb 2025 18:49:12 +0100
From: Jiri Olsa <olsajiri@...il.com>
To: Jiri Olsa <olsajiri@...il.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Kumar Kartikeya Dwivedi <memxor@...il.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, bpf <bpf@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Yan Zhai <yan@...udflare.com>
Subject: Re: [PATCH v2 bpf] net: Add rx_skb of kfree_skb to
 raw_tp_null_args[].

On Sun, Feb 02, 2025 at 11:06:26AM +0100, Jiri Olsa wrote:
> On Sat, Feb 01, 2025 at 09:15:28AM +0100, Alexei Starovoitov wrote:
> > On Sat, Feb 1, 2025 at 9:13 AM Jiri Olsa <olsajiri@...il.com> wrote:
> > >
> > > > v2:
> > > >   * Add kfree_skb to raw_tp_null_args[] instead of annotating
> > > >     rx_skb with __nullable
> > >
> > > Acked-by: Jiri Olsa <jolsa@...nel.org>
> > 
> > Jiri, Kumar,
> > how come that we missed it earlier?
> > Is this a new change in the tracepoint?
> 
> must have slipped, sry.. I'll double check tracepoints again

sry for late reply, I was traveling last week

I overlooked tracepoints defined in drivers directly :-\

however there was one recent change adding the null check:
  9ab96b524dce hugetlb: fix NULL pointer dereference in trace_hugetlbfs_alloc_inode

will send update shortly

jirka