netdev - Re: [PATCH net-next v6 2/6] dt-bindings: net: Add Realtek MDIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173868503036.2827831.5451264142133943992.robh@kernel.org>
Date: Tue, 4 Feb 2025 10:03:50 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: netdev@...r.kernel.org, linux-mips@...r.kernel.org,
	devicetree@...r.kernel.org, hkallweit1@...il.com, kuba@...nel.org,
	conor+dt@...nel.org, lee@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, pabeni@...hat.com, tsbogend@...ha.franken.de,
	linux@...linux.org.uk, sander@...nheule.net, krzk+dt@...nel.org,
	markus.stockhausen@....de, daniel@...rotopia.org,
	linux-kernel@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next v6 2/6] dt-bindings: net: Add Realtek MDIO
 controller


On Tue, 04 Feb 2025 16:02:45 +1300, Chris Packham wrote:
> Add dtschema for the MDIO controller found in the RTL9300 SoCs. The
> controller is slightly unusual in that direct MDIO communication is not
> possible. We model the MDIO controller with the MDIO buses as child
> nodes and the PHYs as children of the buses. The mapping of switch port
> number to MDIO bus/addr requires the ethernet-ports sibling to provide
> the mapping via the phy-handle property.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v6:
>     - Remove realtek,port property. The driver will parse the ethernet-ports
>       sibling node to figure out the mapping (do I need to mention that
>       somewhere in this binding?).
>     - Correct number of mdio buses. 4 possible buses numbered 0-3.
>     Changes in v5:
>     - Add back reg property to mdio-controller node
>     - Make unit address in the node name required
>     - Andrew suggested perhaps doing away with the realtek,port property and
>       providing the overall mapping via an array of phandles. I've explored
>       this a little, it is doable but I'm not sure it actually makes things
>       any clearer when the portmap has gaps so I haven't made this change.
>     Changes in v4:
>     - Model the MDIO controller with the buses as child nodes. We still need
>       to deal with the switch port number so this is represented with the
>       "realtek,port" property which needs to be added to the MDIO bus
>       children (i.e. the PHYs)
>     - Because the above is quite a departure from earlier I've dropped the
>       r-by
>     Changes in v3:
>     - Add r-by from Connor
>     Changes in v2:
>     - None
> 
>  .../bindings/net/realtek,rtl9301-mdio.yaml    | 86 +++++++++++++++++++
>  1 file changed, 86 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>