netdev - Re: [PATCH net-next v6 1/6] dt-bindings: mfd: Add switch to RTL9300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3087ea19-8c2a-47c8-adbe-d05009c6f07b@alliedtelesis.co.nz>
Date: Tue, 4 Feb 2025 20:14:50 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "lee@...nel.org" <lee@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "tsbogend@...ha.franken.de"
	<tsbogend@...ha.franken.de>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "sander@...nheule.net"
	<sander@...nheule.net>, "daniel@...rotopia.org" <daniel@...rotopia.org>,
	"markus.stockhausen@....de" <markus.stockhausen@....de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH net-next v6 1/6] dt-bindings: mfd: Add switch to RTL9300

Hi Krzysztof,

On 04/02/2025 21:09, Krzysztof Kozlowski wrote:
> On Tue, Feb 04, 2025 at 04:02:44PM +1300, Chris Packham wrote:
>> Add bindings for the ethernet-switch portion of the RTL9300.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
>> Notes:
>>      Changes in v6:
>>      - New
>>      - I'd like to enforce the property being "ethernet-ports" but I see the
>>        generic binding allows "ports" as well. Can I just add ethernet-ports:
>>        type: object here or does by driver need to handle both "ports" and
>>        "ethernet-ports" (I see some do and some don't).
>>
>>   .../bindings/mfd/realtek,rtl9301-switch.yaml     | 16 +++++++++++++++-
>>   1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> index f053303ab1e6..cb54abda5e6a 100644
>> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> @@ -14,6 +14,8 @@ description:
>>     number of different peripherals are accessed through a common register block,
>>     represented here as a syscon node.
>>   
>> +$ref: /schemas/net/ethernet-switch.yaml#
>> +
>>   properties:
>>     compatible:
>>       items:
>> @@ -45,7 +47,7 @@ required:
>>     - compatible
>>     - reg
>>   
> I don't get why this device receives now children without addresses.
> Either your children have 'reg' or they do not. Mixing is a sign of a
> mess, like this was never actually simple-mfd.
>
> You would get this comment if you posted complete schema the first time.

Yes fair enough. I think I erred too far on the side of trying to send 
small chunks (and also not wanting to commit to a binding before I had 
working drivers).

So how do we move forward? There's one more patch I haven't sent yet 
that adds interrupts for the switch block. But other than that I think 
what I have now covers all of the major components in this chip.

There's only one in-tree board that uses this and I'm the maintainer of 
it so withdrawing the mfd binding and replacing it with something else 
is not out of the question. There may be some complaints from make 
dtbs_check while we get this sorted but hopefully we can get that done soon.