netdev - Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fcca70c-9bfe-4fd7-b82d-e21f765b8b87@blackwall.org>
Date: Wed, 5 Feb 2025 14:12:50 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Ted Chen <znscnchen@...il.com>, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch
Cc: netdev@...r.kernel.org, Ido Schimmel <idosch@...sch.org>
Subject: Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde
 ipv6

On 2/5/25 13:44, Ted Chen wrote:
> Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
> invoke vxlan_rcv() to process packets.
> 
> The comment aligns with that for vxlan_err_lookup().
> 
> Cc: Ido Schimmel <idosch@...sch.org>
> Signed-off-by: Ted Chen <znscnchen@...il.com>
> ---
>  drivers/net/vxlan/vxlan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 5ef40ac816cc..8bdf91d1fdfe 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
>  	return err <= 1;
>  }
>  
> -/* Callback from net/ipv4/udp.c to receive packets */
> +/* Callback from net/ipv{4,6}/udp.c to receive packets */
>  static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
>  {
>  	struct vxlan_vni_node *vninode = NULL;

Your subject has a typo
s/inlucde/include

IMO these comments are unnecessary, encap_rcv callers are trivial to find.

Cheers,
 Nik