netdev - Re: [EXTERNAL] Re: [PATCH net 3/3] net: ti: icssg-prueth: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6Oj7eMRV9z9lF2I@shredder>
Date: Wed, 5 Feb 2025 19:46:21 +0200
From: Ido Schimmel <idosch@...sch.org>
To: "Malladi, Meghana" <m-malladi@...com>
Cc: rogerq@...nel.org, danishanwar@...com, pabeni@...hat.com,
	kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
	andrew+netdev@...n.ch, bpf@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, robh@...nel.org,
	matthias.schiffer@...tq-group.com, dan.carpenter@...aro.org,
	rdunlap@...radead.org, diogo.ivo@...mens.com,
	schnelle@...ux.ibm.com, glaroque@...libre.com,
	john.fastabend@...il.com, hawk@...nel.org, daniel@...earbox.net,
	ast@...nel.org, srk@...com, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [EXTERNAL] Re: [PATCH net 3/3] net: ti: icssg-prueth: Add AF_XDP
 support

On Tue, Feb 04, 2025 at 11:25:39PM +0530, Malladi, Meghana wrote:
> On 1/23/2025 10:55 PM, Ido Schimmel wrote:
> > XDP program could have changed the packet length, but driver seems to be
> 
> This will be true given, emac->xdp_prog is not NULL. What about when XDP is
> not enabled ?

I don't understand the question. My point is that the packet doesn't
necessarily look the same after XDP ran.

> 
> > building the skb using original length read from the descriptor.
> > Consider using xdp_build_skb_from_buff()
> > 
>