netdev - Re: [PATCH bpf-next v8 05/12] net-timestamp: prepare for isolating two modes of SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoATMrBd_b8==4fu-Nj4xB33X+F8t7RhKetAnhA_zTGJ9g@mail.gmail.com>
Date: Wed, 5 Feb 2025 11:23:30 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	dsahern@...nel.org, willemdebruijn.kernel@...il.com, willemb@...gle.com, 
	ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev, 
	eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev, 
	john.fastabend@...il.com, kpsingh@...nel.org, sdf@...ichev.me, 
	haoluo@...gle.com, jolsa@...nel.org, horms@...nel.org, bpf@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v8 05/12] net-timestamp: prepare for isolating
 two modes of SO_TIMESTAMPING

On Wed, Feb 5, 2025 at 11:14 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 5 Feb 2025 10:40:42 +0800 Jason Xing wrote:
> > I wonder if we need a separate cleanup after this series about moving
> > this kind of functions into net/core/timestamping.c, say,
> > __skb_tstamp_tx()?
>
> IMHO no need to go too far, just move the one function as part of this
> series. The only motivation is to avoid adding includes to
> linux/skbuff.h since skbuff.h is included in something like 8k objects.

Thanks for clarifying. Will do it in the re-spin.

Thanks,
Jason