netdev - Re: [PATCH v2 1/2] net, treewide: define and use MAC_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d70ec0708ec351efb530a53f0a2c6ad0503bcbb.camel@sipsolutions.net>
Date: Wed, 05 Feb 2025 08:25:46 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Uday Shankar <ushankar@...estorage.com>, Breno Leitao
 <leitao@...ian.org>,  Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet	 <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni	 <pabeni@...hat.com>, Srinivas
 Kandagatla <srinivas.kandagatla@...aro.org>, 
 Rafał Miłecki	 <rafal@...ecki.pl>, Simon Horman
 <horms@...nel.org>, Andrew Morton	 <akpm@...ux-foundation.org>, Jonathan
 Corbet <corbet@....net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] net, treewide: define and use MAC_ADDR_LEN

On Tue, 2025-02-04 at 14:41 -0700, Uday Shankar wrote:
> There are a few places in the tree which compute the length of the
> string representation of a MAC address as 3 * ETH_ALEN - 1. Define a
> constant for this and use it where relevant. No functionality changes
> are expected.

True ... but is "MAC_ADDR_LEN" really an appropriate name for that? Just
plain reading the subject, my first thought was why you weren't going to
use ETH_ALEN.

Would seem nicer to me, at least, to have something indicating a
*string* in there, e.g. MAC_ADDR_STR_LEN or so.

johannes