netdev - Re: [PATCH] seg6: inherit inner IPv4 TTL on ip4ip6 encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0ccfff2-3995-430b-b762-e055861c4247@chinatelecom.cn>
Date: Wed, 5 Feb 2025 15:25:21 +0800
From: YonglongLi <liyonglong@...natelecom.cn>
To: Jakub Kicinski <kuba@...nel.org>,
 Ahmed Abdelsalam <ahabdels.dev@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, dsahern@...nel.org,
 edumazet@...gle.com, liyonglong@...antelecom.cn
Subject: Re: [PATCH] seg6: inherit inner IPv4 TTL on ip4ip6 encapsulation



On 1/23/2025 23:48, 【外部账号】 Jakub Kicinski wrote:
> On Wed, 22 Jan 2025 11:20:05 +0100 Ahmed Abdelsalam wrote:
>> This patch is not RFC complaint. Section 6.3 of RFC 2473 (Generic Packet
>> Tunneling in IPv6 Specification) discussed IPv6 Tunnel Hop Limit.
>> The hop limit field of the tunnel IPv6 header of each packet encapsulated
>> is set to the hop limit default value of the tunnel entry-point ode.
>> The SRv6 RFC (RFC 8986) inherits the tunnel behavior from RFC2473l
> 
> I see. I think this information would be good to have in the commit
> message. IIRC we do inherit already in other tunnel implementations, 
> ideally we should elaborate on precedents in Linux behavior in the
> commit message, too.
> 
> reminder: please don't top post on the list
> 

Sorry for the late relay. And thanks for your review.

Is it ok that copying inner hop limit(TTL) on SRv6 encapsulation just
like what ip/ip6 tunnel does in Linux implementation?
if it is ok, I will send v2 which will add more detailed commit message.

-- 
Li YongLong