netdev - Re: [PATCH net-next 1/2] usb: Add base USB MCTP definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a927fbb40ce2f89c57b427d4dabe5f730a523d80.camel@codeconstruct.com.au>
Date: Thu, 06 Feb 2025 15:11:25 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Matt Johnston <matt@...econstruct.com.au>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-usb@...r.kernel.org,  Santosh Puranik <spuranik@...dia.com>
Subject: Re: [PATCH net-next 1/2] usb: Add base USB MCTP definitions

Hi Greg,

Thanks for the review.

> > --- /dev/null
> > +++ b/include/linux/usb/mctp-usb.h
> > @@ -0,0 +1,28 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/*
> > + * mctp-usb.h - MCTP USB transport binding: common definitions.
> > + *
> > + * These are protocol-level definitions, that may be shared between host
> > + * and gadget drivers.
> 
> Perhaps add a link to the spec?

Can do. I have one in the actual driver, but can replicate that here if
it's helpful.

> > + *
> > + * Copyright (C) 2024 Code Construct Pty Ltd
> 
> It's 2025 now :)

WHAT?!

:D

(this was started in 2024, and I have some preliminary versions up since
then, but I assume the last date is preferrable)

Unless I hear otherwise, I'll v2 this after a netdev-appropriate
backoff, with the added link and 2025 for both patches.

Cheers,

Jeremy