netdev - Re: [PATCH net-next 1/2] usb: Add base USB MCTP definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025020634-statute-ribbon-90a8@gregkh>
Date: Thu, 6 Feb 2025 08:22:47 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jeremy Kerr <jk@...econstruct.com.au>
Cc: Matt Johnston <matt@...econstruct.com.au>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Santosh Puranik <spuranik@...dia.com>
Subject: Re: [PATCH net-next 1/2] usb: Add base USB MCTP definitions

On Thu, Feb 06, 2025 at 03:11:25PM +0800, Jeremy Kerr wrote:
> Hi Greg,
> 
> Thanks for the review.
> 
> > > --- /dev/null
> > > +++ b/include/linux/usb/mctp-usb.h
> > > @@ -0,0 +1,28 @@
> > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > > +/*
> > > + * mctp-usb.h - MCTP USB transport binding: common definitions.
> > > + *
> > > + * These are protocol-level definitions, that may be shared between host
> > > + * and gadget drivers.
> > 
> > Perhaps add a link to the spec?
> 
> Can do. I have one in the actual driver, but can replicate that here if
> it's helpful.

Isn't this a usb.org spec and not a vendor-specific one?

> > > + * Copyright (C) 2024 Code Construct Pty Ltd
> > 
> > It's 2025 now :)
> 
> WHAT?!
> 
> :D
> 
> (this was started in 2024, and I have some preliminary versions up since
> then, but I assume the last date is preferrable)

As per copyright norms, list the real dates, so that would be:
	Copyright (C) 2024-2025 ...

thanks,

greg k-h