netdev - Re: [PATCH net-next v7 4/6] net: libwx: Add msg task func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207171739.7ab11585@kernel.org>
Date: Fri, 7 Feb 2025 17:17:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: mengyuanlou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com,
 duanqiangwen@...-swift.com
Subject: Re: [PATCH net-next v7 4/6] net: libwx: Add msg task func

On Thu,  6 Feb 2025 18:37:48 +0800 mengyuanlou wrote:
> +static int wx_negotiate_vf_api(struct wx *wx, u32 *msgbuf, u32 vf)
> +{
> +	int api = msgbuf[1];
> +
> +	switch (api) {
> +	case wx_mbox_api_10 ... wx_mbox_api_13:
> +		wx->vfinfo[vf].vf_api = api;
> +		return 0;
> +	default:
> +		wx_err(wx, "VF %d requested invalid api version %u\n", vf, api);
> +		return -EINVAL;
> +	}
> +}

How "compatible" is your device with IXGBE?

static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter,                
                                  u32 *msgbuf, u32 vf)                          
{                                                                               
        int api = msgbuf[1];                                                    
                                                                                
        switch (api) {                                                          
        case ixgbe_mbox_api_10:                                                 
        case ixgbe_mbox_api_11:                                                 
        case ixgbe_mbox_api_12:                                                 
        case ixgbe_mbox_api_13:                                                 
        case ixgbe_mbox_api_14:                                                 
                adapter->vfinfo[vf].vf_api = api;                               
                return 0;                                                       
        default:                                                                
                break;                                                          
        }                                                                       
                                                                                
        e_dbg(drv, "VF %d requested unsupported api version %u\n", vf, api);    
                                                                                
        return -1;                                                              
}