netdev - Re: [PATCH net-next v5 2/7] net: phy: Support speed selection for PHY loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250207161614.6a70bef6@kernel.org>
Date: Fri, 7 Feb 2025 16:16:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 2/7] net: phy: Support speed selection for
 PHY loopback

On Wed,  5 Feb 2025 20:08:18 +0100 Gerhard Engleder wrote:
> +/**
> + * phy_loopback - Configure loopback mode of PHY
> + * @phydev: target phy_device struct
> + * @enable: enable or disable loopback mode
> + * @speed: enable loopback mode with speed
> + *
> + * Configure loopback mode of PHY and signal link down and link up if speed is
> + * changing.
> + */
> +int phy_loopback(struct phy_device *phydev, bool enable, int speed)

nit: if you're adding kdoc please also document the return value.

 * Return: 0 on success, negative error code on failure.
-- 
pw-bot: cr