netdev - Re: [PATCH net-next v5 2/7] net: phy: Support speed selection for PHY loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d93e1b3a-ac9d-4e0f-b33d-468928e4bdab@engleder-embedded.com>
Date: Sun, 9 Feb 2025 19:52:21 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 2/7] net: phy: Support speed selection for PHY
 loopback

On 08.02.25 01:16, Jakub Kicinski wrote:
> On Wed,  5 Feb 2025 20:08:18 +0100 Gerhard Engleder wrote:
>> +/**
>> + * phy_loopback - Configure loopback mode of PHY
>> + * @phydev: target phy_device struct
>> + * @enable: enable or disable loopback mode
>> + * @speed: enable loopback mode with speed
>> + *
>> + * Configure loopback mode of PHY and signal link down and link up if speed is
>> + * changing.
>> + */
>> +int phy_loopback(struct phy_device *phydev, bool enable, int speed)
> 
> nit: if you're adding kdoc please also document the return value.
> 
>   * Return: 0 on success, negative error code on failure.

Sorry, I missed that. Will add return value documentation.

Thank you for the review!

Gerhard