netdev - RE: [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62190D71B315202FB7BB4D8A92F22@IA1PR11MB6219.namprd11.prod.outlook.com>
Date: Mon, 10 Feb 2025 10:54:34 +0000
From: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>
Subject: RE: [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, February 7, 2025 11:04 AM
> To: Nitka, Grzegorz <grzegorz.nitka@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Kolacinski, Karol
> <karol.kolacinski@...el.com>
> Subject: Re: [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C
> 
> On Thu, Feb 06, 2025 at 09:36:53AM +0100, Grzegorz Nitka wrote:
> > From: Karol Kolacinski <karol.kolacinski@...el.com>
> >
> > Implement setting GLTSYN_SYNC_DLAY for E825C products.
> > This is the execution delay compensation of SYNC command between
> > PHC and PHY.
> > Also, refactor the code by changing ice_ptp_init_phc_eth56g function
> > name to ice_ptp_init_phc_e825, to be consistent with the naming pattern
> > for other devices.
> 
> Adding support for GLTSYN_SYNC_DLAY and the refactor seem
> to be two distinct changes, albeit touching common code.
> 
> I think it would be slightly better to split this into two patches.
> 
Sure, will exclude this commit from the series and will submit it as separate patch.
Thanks for your review and valuable feedback.

> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> 
> ...