netdev - RE: [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6219E9A67D79B4045ED0765592F22@IA1PR11MB6219.namprd11.prod.outlook.com>
Date: Mon, 10 Feb 2025 11:05:30 +0000
From: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>
Subject: RE: [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info
 struct

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, February 7, 2025 11:06 AM
> To: Nitka, Grzegorz <grzegorz.nitka@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Kolacinski, Karol
> <karol.kolacinski@...el.com>
> Subject: Re: [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info
> struct
> 
> On Fri, Feb 07, 2025 at 10:03:45AM +0000, Simon Horman wrote:
> > On Thu, Feb 06, 2025 at 09:36:54AM +0100, Grzegorz Nitka wrote:
> > > From: Karol Kolacinski <karol.kolacinski@...el.com>
> > >
> > > Simplify ice_phy_reg_info_eth56g struct definition to include base
> > > address for the very first quad. Use base address info and 'step'
> > > value to determine address for specific PHY quad.
> > >
> > > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> > > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> >
> > Reviewed-by: Simon Horman <horms@...nel.org>
> 
> Sorry, I failed to notice that the kdoc for ice_phy_reg_info_eth56g
> needs to be updated to document base_addr instead of base.

Good catch! Thanks! To be fixed in v2.