netdev - Re: [PATCH net v2 1/2] vsock: Orphan socket after transport release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a181a14-a665-4796-bec7-d73dcc39a319@rbox.co>
Date: Mon, 10 Feb 2025 13:43:40 +0100
From: Michal Luczaj <mhal@...x.co>
To: Luigi Leonardi <leonardi@...hat.com>
Cc: Stefano Garzarella <sgarzare@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 syzbot+9d55b199192a4be7d02c@...kaller.appspotmail.com
Subject: Re: [PATCH net v2 1/2] vsock: Orphan socket after transport release

On 2/10/25 11:24, Luigi Leonardi wrote:
> Hi Michal,
> 
> On Thu, Feb 06, 2025 at 12:06:47AM +0100, Michal Luczaj wrote:
>> During socket release, sock_orphan() is called without considering that it
>> sets sk->sk_wq to NULL. Later, if SO_LINGER is enabled, this leads to a
>> null pointer dereferenced in virtio_transport_wait_close().
>>
>> Orphan the socket only after transport release.
>>
>> While there, reflow the other comment.
> May I ask you why?

For aesthetic purposes only :)

> ...
> Code LGTM!
> 
> I probably wouldn't have changed that comment because of possible 
> conflicts.
> 
> Reviewed-by: Luigi Leonardi <leonardi@...hat.com>

Got it, dropping the old comment reflow, thanks.

Michal