netdev - Re: [PATCH net v2 1/2] vsock: Orphan socket after transport release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f253267-2277-4a96-b732-ebbed46e023a@rbox.co>
Date: Mon, 10 Feb 2025 13:43:53 +0100
From: Michal Luczaj <mhal@...x.co>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org,
 syzbot+9d55b199192a4be7d02c@...kaller.appspotmail.com,
 Luigi Leonardi <leonardi@...hat.com>
Subject: Re: [PATCH net v2 1/2] vsock: Orphan socket after transport release

On 2/10/25 11:15, Stefano Garzarella wrote:
> On Thu, Feb 06, 2025 at 12:06:47AM +0100, Michal Luczaj wrote:
>> ...
>> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>> index 075695173648d3a4ecbd04e908130efdbb393b41..85d20891b771a25b8172a163983054a2557f98c1 100644
>> --- a/net/vmw_vsock/af_vsock.c
>> +++ b/net/vmw_vsock/af_vsock.c
>> @@ -817,20 +817,25 @@ static void __vsock_release(struct sock *sk, int level)
>> 	vsk = vsock_sk(sk);
>> 	pending = NULL;	/* Compiler warning. */
>>
>> -	/* When "level" is SINGLE_DEPTH_NESTING, use the nested
>> -	 * version to avoid the warning "possible recursive locking
>> -	 * detected". When "level" is 0, lock_sock_nested(sk, level)
>> -	 * is the same as lock_sock(sk).
>> +	/* When "level" is SINGLE_DEPTH_NESTING, use the nested version to avoid
>> +	 * the warning "possible recursive locking detected". When "level" is 0,
>> +	 * lock_sock_nested(sk, level) is the same as lock_sock(sk).
> 
> This comment is formatted “weird” because recently in commit
> 135ffc7becc8 ("bpf, vsock: Invoke proto::close on close()") we reduced
> the indentation without touching the comment.
> 
> Since this is a fix we may have to backport into stable branches without
> that commit, I would avoid touching it to avoid unnecessary conflicts.
> ...

I've checked that 135ffc7becc8 was already backported (6.1, 6.6, 6.12) and
thought it's safe to do, but I understand your concern, so sending v3
without touching the other comment.

Thanks,
Michal