netdev - Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_dFoJ056xR2BW5eZeg_b7ZfHhM9_6iuGM8MbsUJSipm+A@mail.gmail.com>
Date: Mon, 10 Feb 2025 14:18:43 -0500
From: Xin Long <lucien.xin@...il.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc: netdev@...r.kernel.org, linux-sctp@...r.kernel.org, 
	thorsten.blum@...ux.dev
Subject: Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

On Mon, Feb 10, 2025 at 12:35 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Mon, Feb 10, 2025 at 11:44:10AM -0500, Xin Long wrote:
> > On Mon, Feb 10, 2025 at 8:25 AM Marcelo Ricardo Leitner
> > <marcelo.leitner@...il.com> wrote:
> > >
> > > All SCTP patches are picked up by netdev maintainers. Two headers were
> > > missing to be listed there.
> > >
> > > Reported-by: Thorsten Blum <thorsten.blum@...ux.dev>
> > > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> > > ---
> > >  MAINTAINERS | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 873aa2cce4d7fd5fd31613edbf3d99faaf7810bd..34ff998079d4c4843336936e47bd74c0e919012b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -16509,6 +16509,7 @@ F:      include/linux/netdev*
> > >  F:     include/linux/netlink.h
> > >  F:     include/linux/netpoll.h
> > >  F:     include/linux/rtnetlink.h
> > > +F:     include/linux/sctp.h
> > >  F:     include/linux/seq_file_net.h
> > >  F:     include/linux/skbuff*
> > >  F:     include/net/
> > > @@ -16525,6 +16526,7 @@ F:      include/uapi/linux/netdev*
> > >  F:     include/uapi/linux/netlink.h
> > >  F:     include/uapi/linux/netlink_diag.h
> > >  F:     include/uapi/linux/rtnetlink.h
> > > +F:     include/uapi/linux/sctp.h
> > >  F:     lib/net_utils.c
> > >  F:     lib/random32.c
> > >  F:     net/
> >
> > Checking some other subcomponents like: MPTCP, TIPC, OPENVSWITCH,
> > HANDSHAKE UPCALL ...
> >
> > It seems that we should append:
> >
> >   L:      netdev@...r.kernel.org
> >
> > after:
> >
> >   L:      linux-sctp@...r.kernel.org
> >
> > in the section:
> >
> >   SCTP PROTOCOL
>
> You mean, "also" append, right? And not "instead". Because currently
> the NET one includes all other files and it doesn't exclude stuff like
> net/{mptcp,sctp}.
I'm thinking it should be "instead".

Yes, all files under include/net/ are included in the NET, but those files
(belong to subcomponents/modules) under include/linux/, include/linux/uapi/
or even include/trace/ are included in their own sections and not in the
NET, such as:

include/uapi/linux/mptcp*.h
include/trace/events/mptcp.h
include/uapi/linux/tipc*.h
include/uapi/linux/openvswitch.h
include/trace/events/handshake.h

Thanks.