netdev - Re: [PATCH net-next v6 00/12] Begin upstreaming Homa transport protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXJAmxHZ=uA1F5Sxd1VofoadUve+iaA3BS+C0_qHY=0yBLR8w@mail.gmail.com>
Date: Mon, 10 Feb 2025 11:19:36 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, horms@...nel.org, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v6 00/12] Begin upstreaming Homa transport protocol

On Fri, Jan 24, 2025 at 12:55 AM Paolo Abeni <pabeni@...hat.com> wrote:
> I haven't completed reviewing the current iteration yet, but with the
> amount of code inspected at this point, the series looks quite far from
> a mergeable status.
>
> Before the next iteration, I strongly advice to review (and possibly
> rethink) completely the locking schema, especially the RCU usage, to
> implement rcvbuf and sendbuf accounting (and possibly even memory
> accounting), to reorganize the code for better reviewability (the code
> in each patch should refer/use only the code current and previous
> patches), to use more the existing kernel API and constructs and to test
> the code with all the kernel/configs/debug.config knobs enabled.
>
> Unless a patch is new or completely rewritten from scratch, it would be
> helpful to add per patch changelog, after the SoB tag and a '---' separator.

I should be able to take care of all these things in the next revision.

-John-