netdev - Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <227b48e8-191d-4637-a0c9-3885fbe80845@intel.com>
Date: Mon, 10 Feb 2025 10:23:40 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	Willem de Bruijn <willemb@...gle.com>, Simon Horman <horms@...nel.org>,
	<eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]()



On 2/10/2025 10:08 AM, Eric Dumazet wrote:
> On Mon, Feb 10, 2025 at 9:41 AM Mateusz Polchlopek
> <mateusz.polchlopek@...el.com> wrote:
>>
>>
>>
>> On 2/10/2025 9:28 AM, Eric Dumazet wrote:
>>> Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
>>> to be exported unless CONFIG_IPV6=m
>>>
>>> tcp_hashinfo is no longer used from any module anyway.
>>
>> You also removed EXPORT for tcp_openreq_init_rwin function. Quick
>> grep shows that it is also not used anymore by any module, so probably
>> you forgot to add this info to commit message? Do you think it is worth
>> to add?
> 
> I forgot to add this in the commit message.
> 
> Not sure if this worth a v2, because IPv6 no longer calls this
> function after this old commit

Oh, you are right! It is not used in IPv6. I guess it is not needed to
resend the series, thanks for clarifying

> 
> commit 1fb6f159fd21c640a28eb65fbd62ce8c9f6a777e
> Author: Octavian Purdila <octavian.purdila@...el.com>
> Date:   Wed Jun 25 17:10:02 2014 +0300
> 
>      tcp: add tcp_conn_request
> 
> 
>>
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>> ---
>>
>> [...]
>>
>>> @@ -457,7 +457,6 @@ void tcp_openreq_init_rwin(struct request_sock *req,
>>>                rcv_wnd);
>>>        ireq->rcv_wscale = rcv_wscale;
>>>    }
>>> -EXPORT_SYMBOL(tcp_openreq_init_rwin);
>>
>> Exactly here
> 
> Yes, thanks.