netdev - Re: [PATCH net-next 0/4] net: add EXPORT_IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <448eaa31-97f5-43cb-837f-b55e3b80ec53@intel.com>
Date: Mon, 10 Feb 2025 10:25:40 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, Willem de Bruijn <willemb@...gle.com>, "Simon
 Horman" <horms@...nel.org>, <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 0/4] net: add EXPORT_IPV6_MOD()



On 2/10/2025 9:28 AM, Eric Dumazet wrote:
> In this series I am adding EXPORT_IPV6_MOD and EXPORT_IPV6_MOD_GPL()
> so that we can replace some EXPORT_SYMBOL() when IPV6 is
> not modular.
> 
> This is making all the selected symbols internal to core
> linux networking.
> 
> Eric Dumazet (4):
>    net: introduce EXPORT_IPV6_MOD() and EXPORT_IPV6_MOD_GPL()
>    inetpeer: use EXPORT_IPV6_MOD[_GPL]()
>    tcp: use EXPORT_IPV6_MOD[_GPL]()
>    udp: use EXPORT_IPV6_MOD[_GPL]()
> 
>   include/net/ip.h         |  8 ++++++
>   net/core/secure_seq.c    |  4 +--
>   net/ipv4/inetpeer.c      |  8 +++---
>   net/ipv4/syncookies.c    |  8 +++---
>   net/ipv4/tcp.c           | 48 ++++++++++++++++-----------------
>   net/ipv4/tcp_fastopen.c  |  2 +-
>   net/ipv4/tcp_input.c     | 14 +++++-----
>   net/ipv4/tcp_ipv4.c      | 47 ++++++++++++++++-----------------
>   net/ipv4/tcp_minisocks.c | 11 ++++----
>   net/ipv4/tcp_output.c    | 12 ++++-----
>   net/ipv4/tcp_timer.c     |  4 +--
>   net/ipv4/udp.c           | 57 ++++++++++++++++++++--------------------
>   12 files changed, 114 insertions(+), 109 deletions(-)
> 

The overall looks fine for me, the question from patch3 was a small
nitpick but not important.

For the series please add my RB tag.

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>