netdev - Re: [PATCH net-next] sctp: Remove commented out code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b85e552d-5525-4179-a9c4-6553b711d949@intel.com>
Date: Tue, 11 Feb 2025 11:49:46 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Marcelo Ricardo Leitner
	<marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>
CC: <linux-sctp@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] sctp: Remove commented out code



On 2/11/2025 11:20 AM, Thorsten Blum wrote:
> Remove commented out code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   include/linux/sctp.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/sctp.h b/include/linux/sctp.h
> index 836a7e200f39..812011d8b67e 100644
> --- a/include/linux/sctp.h
> +++ b/include/linux/sctp.h
> @@ -222,7 +222,6 @@ struct sctp_datahdr {
>   	__be16 stream;
>   	__be16 ssn;
>   	__u32 ppid;
> -	/* __u8  payload[]; */
>   };
>   
>   struct sctp_data_chunk {

Hi Thorsten

I don't think we want to remove that piece of code, please refer
to the discussion under the link:

https://lore.kernel.org/netdev/cover.1681917361.git.lucien.xin@gmail.com/

Thanks