netdev - Re: [PATCH net-next 09/11] net: dummy: add dummy shaper API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502111855.5U4I6OK5-lkp@intel.com>
Date: Tue, 11 Feb 2025 18:41:01 +0800
From: kernel test robot <lkp@...el.com>
To: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next 09/11] net: dummy: add dummy shaper API

Hi Stanislav,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-hold-netdev-instance-lock-during-ndo_open-ndo_stop/20250211-032336
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250210192043.439074-10-sdf%40fomichev.me
patch subject: [PATCH net-next 09/11] net: dummy: add dummy shaper API
config: i386-randconfig-013-20250211 (https://download.01.org/0day-ci/archive/20250211/202502111855.5U4I6OK5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250211/202502111855.5U4I6OK5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502111855.5U4I6OK5-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/dummy.c:129:10: error: 'const struct net_device_ops' has no member named 'net_shaper_ops'
     129 |         .net_shaper_ops         = &dummy_shaper_ops,
         |          ^~~~~~~~~~~~~~
>> drivers/net/dummy.c:129:35: error: initialization of 'int (*)(struct net_device *, struct netdev_phys_item_id *)' from incompatible pointer type 'const struct net_shaper_ops *' [-Werror=incompatible-pointer-types]
     129 |         .net_shaper_ops         = &dummy_shaper_ops,
         |                                   ^
   drivers/net/dummy.c:129:35: note: (near initialization for 'dummy_netdev_ops.ndo_get_phys_port_id')
   cc1: some warnings being treated as errors


vim +129 drivers/net/dummy.c

   120	
   121	static const struct net_device_ops dummy_netdev_ops = {
   122		.ndo_init		= dummy_dev_init,
   123		.ndo_start_xmit		= dummy_xmit,
   124		.ndo_validate_addr	= eth_validate_addr,
   125		.ndo_set_rx_mode	= set_multicast_list,
   126		.ndo_set_mac_address	= eth_mac_addr,
   127		.ndo_get_stats64	= dummy_get_stats64,
   128		.ndo_change_carrier	= dummy_change_carrier,
 > 129		.net_shaper_ops		= &dummy_shaper_ops,
   130	};
   131	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki