netdev - Re: [PATCH net-next 04/11] net: hold netdev instance lock during rtnetlink operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502112254.DdkYlmMx-lkp@intel.com>
Date: Tue, 11 Feb 2025 23:06:52 +0800
From: kernel test robot <lkp@...el.com>
To: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next 04/11] net: hold netdev instance lock during
 rtnetlink operations

Hi Stanislav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-hold-netdev-instance-lock-during-ndo_open-ndo_stop/20250211-032336
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250210192043.439074-5-sdf%40fomichev.me
patch subject: [PATCH net-next 04/11] net: hold netdev instance lock during rtnetlink operations
config: arc-randconfig-001-20250211 (https://download.01.org/0day-ci/archive/20250211/202502112254.DdkYlmMx-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250211/202502112254.DdkYlmMx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502112254.DdkYlmMx-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/core/dev.c: In function 'dev_set_mtu':
   net/core/dev.c:9320:15: error: implicit declaration of function 'netdev_set_mtu_ext_locked'; did you mean 'netdev_ops_assert_locked'? [-Werror=implicit-function-declaration]
    9320 |         err = netdev_set_mtu_ext_locked(dev, new_mtu, &extack);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
         |               netdev_ops_assert_locked
   net/core/dev.c: At top level:
>> net/core/dev.c:11390:12: warning: 'netdev_lock_cmp_fn' defined but not used [-Wunused-function]
   11390 | static int netdev_lock_cmp_fn(const struct lockdep_map *a, const struct lockdep_map *b)
         |            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
>> net/core/dev_api.c:109: warning: Excess function parameter 'new_ifindex' description in 'dev_change_net_namespace'


vim +/netdev_lock_cmp_fn +11390 net/core/dev.c

 11389	
 11390	static int netdev_lock_cmp_fn(const struct lockdep_map *a, const struct lockdep_map *b)
 11391	{
 11392		/* Only lower devices currently grab the instance lock, so no
 11393		 * real ordering issues can occur. In the near future, only
 11394		 * hardware devices will grab instance lock which also does not
 11395		 * involve any ordering. Suppress lockdep ordering warnings
 11396		 * until (if) we start grabbing instance lock on pure SW
 11397		 * devices (bond/team/etc).
 11398		 */
 11399		return -1;
 11400	}
 11401	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki