netdev - Re: [PATCH net-next v2 2/2] net: Add dev_getbyhwaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9B3D8CD0-65DE-43FE-88BA-55902DE96496@amazon.co.jp>
Date: Tue, 11 Feb 2025 11:49:14 +0000
From: "Iwashima, Kuniyuki" <kuniyu@...zon.co.jp>
To: Breno Leitao <leitao@...ian.org>, Uday Shankar <ushankar@...estorage.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "kernel-team@...a.com" <kernel-team@...a.com>
Subject: Re: [PATCH net-next v2 2/2] net: Add dev_getbyhwaddr_rtnl() helper

From: Breno Leitao <leitao@...ian.org>
Date: Tue, 11 Feb 2025 03:36:43 -0800
> > > +struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type,
> > > +                              const char *ha)
> > > +{
> > > +   struct net_device *dev;
> > > +
> > > +   ASSERT_RTNL();
> > > +   for_each_netdev(net, dev)
> > > +           if (dev_comp_addr(dev, type, ha))
> > > +                   return dev;
> > > +
> > > +   return NULL;
> > > +}
> > > +EXPORT_SYMBOL(dev_getbyhwaddr);
> >
> > Commit title should change to reflect the new function name in v2.
> >
> > Separately - how should I combine this with
> > https://lore.kernel.org/netdev/20250205-netconsole-v3-0-132a31f17199@purestorage.com/?
> > I see three options:
> > - combine the two series into one
> 
> I would suggest you combine the two series into one.
> 
> I will send a v3 today adjusting the comments, and you can integrated
> them into your patchset.

I suggest Breno post v3 for net.git with arp fix and then net.git
will be merged to net-next on Thursday, then Uday can respin.

If this is posted to net-next.git, the following arp fix needs to
wait for the next cycle so that net-next.git will be merged to
net.git.