netdev - Re: [PATCH net-next v2 2/2] net: Add dev_getbyhwaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250211-spectral-golden-quoll-ed1af9@leitao>
Date: Tue, 11 Feb 2025 05:16:23 -0800
From: Breno Leitao <leitao@...ian.org>
To: "Iwashima, Kuniyuki" <kuniyu@...zon.co.jp>
Cc: Uday Shankar <ushankar@...estorage.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-team@...a.com" <kernel-team@...a.com>
Subject: Re: [PATCH net-next v2 2/2] net: Add dev_getbyhwaddr_rtnl() helper

On Tue, Feb 11, 2025 at 11:49:14AM +0000, Iwashima, Kuniyuki wrote:
> From: Breno Leitao <leitao@...ian.org>
> Date: Tue, 11 Feb 2025 03:36:43 -0800
> > > > +struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type,
> > > > +                              const char *ha)
> > > > +{
> > > > +   struct net_device *dev;
> > > > +
> > > > +   ASSERT_RTNL();
> > > > +   for_each_netdev(net, dev)
> > > > +           if (dev_comp_addr(dev, type, ha))
> > > > +                   return dev;
> > > > +
> > > > +   return NULL;
> > > > +}
> > > > +EXPORT_SYMBOL(dev_getbyhwaddr);
> > >
> > > Commit title should change to reflect the new function name in v2.
> > >
> > > Separately - how should I combine this with
> > > https://lore.kernel.org/netdev/20250205-netconsole-v3-0-132a31f17199@purestorage.com/?
> > > I see three options:
> > > - combine the two series into one
> > 
> > I would suggest you combine the two series into one.
> > 
> > I will send a v3 today adjusting the comments, and you can integrated
> > them into your patchset.
> 
> I suggest Breno post v3 for net.git with arp fix and then net.git
> will be merged to net-next on Thursday, then Uday can respin.
> 
> If this is posted to net-next.git, the following arp fix needs to
> wait for the next cycle so that net-next.git will be merged to
> net.git.

Why not sending both patches all together in a patchset against
net-next?