netdev - Re: [PATCH net-next 03/11] net: hold netdev instance lock during queue operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250211182158.1fe9c554@kernel.org>
Date: Tue, 11 Feb 2025 18:21:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next 03/11] net: hold netdev instance lock during
 queue operations

On Mon, 10 Feb 2025 11:20:35 -0800 Stanislav Fomichev wrote:
> -	netif_napi_add(priv->dev, &block->napi, gve_poll);
> -	netif_napi_set_irq(&block->napi, block->irq);
> +	netdev_assert_locked(priv->dev);
> +	netif_napi_add_locked(priv->dev, &block->napi, gve_poll);
> +	netif_napi_set_irq_locked(&block->napi, block->irq);
>  }
>  
>  void gve_remove_napi(struct gve_priv *priv, int ntfy_idx)
>  {
>  	struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];
>  
> -	netif_napi_del(&block->napi);
> +	netdev_assert_locked(priv->dev);
> +	netif_napi_del_locked(&block->napi);

nit: probably don't need the asserts right above _locked() calls
I think the _locked() calls already assert