netdev - Re: [PATCH net-next v1] page_pool: avoid infinite loop to schedule delayed worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250211194326.63ac6be7@kernel.org>
Date: Tue, 11 Feb 2025 19:43:26 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Mina Almasry <almasrymina@...gle.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, hawk@...nel.org,
 ilias.apalodimas@...aro.org, horms@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1] page_pool: avoid infinite loop to schedule
 delayed worker

On Wed, 12 Feb 2025 11:20:16 +0800 Jason Xing wrote:
> On Wed, Feb 12, 2025 at 10:46 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Tue, 11 Feb 2025 18:37:22 -0800 Mina Almasry wrote:  
> > > Isn't it the condition in page_pool_release_retry() that you want. to
> > > modify? That is the one that handles whether the worker keeps spinning
> > > no?  
> >
> > +1
> >
> > A code comment may be useful BTW.  
> 
> I will add it in the next version. Yes, my intention is to avoid
> initializing the delayed work since we don't expect the worker in
> page_pool_release_retry() to try over and over again.

Initializing a work isn't much cost, is it?

Just to state the obvious the current patch will not catch the
situation when there is traffic outstanding (inflight is positive)
at the time of detach from the driver. But then the inflight goes
negative before the work / time kicks in.