netdev - Re: [PATCH net-next 04/10] ice: Process TSYN IRQ in a separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250211194727.59090a33@kernel.org>
Date: Tue, 11 Feb 2025 19:47:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org, Karol Kolacinski
 <karol.kolacinski@...el.com>, richardcochran@...il.com,
 grzegorz.nitka@...el.com, przemyslaw.kitszel@...el.com
Subject: Re: [PATCH net-next 04/10] ice: Process TSYN IRQ in a separate
 function

On Mon, 10 Feb 2025 11:23:42 -0800 Tony Nguyen wrote:
> Simplify TSYN IRQ processing by moving it to a separate function and
> having appropriate behavior per PHY model, instead of multiple
> conditions not related to HW, but to specific timestamping modes.
> 
> When PTP is not enabled in the kernel, don't process timestamps and
> return IRQ_HANDLED.

You also switched from spin_lock_irqsave() to bare spin_lock().
Looks safe but you should have mentioned why.