netdev - Re: [PATCH v2 net-next 3/4] tcp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13eb84d9-f562-424e-b680-229d80ac0cb7@intel.com>
Date: Thu, 13 Feb 2025 08:27:33 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, Simon Horman <horms@...nel.org>, "Willem de
 Bruijn" <willemb@...gle.com>, Sabrina Dubroca <sd@...asysnail.net>, "Neal
 Cardwell" <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	<eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]()



On 2/12/2025 2:24 PM, Eric Dumazet wrote:
> Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
> to be exported unless CONFIG_IPV6=m
> 
> tcp_hashinfo and tcp_openreq_init_rwin() are no longer
> used from any module anyway.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>   net/core/secure_seq.c    |  2 +-
>   net/ipv4/syncookies.c    |  8 +++----
>   net/ipv4/tcp.c           | 44 ++++++++++++++++++-------------------
>   net/ipv4/tcp_fastopen.c  |  2 +-
>   net/ipv4/tcp_input.c     | 14 ++++++------
>   net/ipv4/tcp_ipv4.c      | 47 ++++++++++++++++++++--------------------
>   net/ipv4/tcp_minisocks.c | 11 +++++-----
>   net/ipv4/tcp_output.c    | 12 +++++-----
>   net/ipv4/tcp_timer.c     |  4 ++--
>   9 files changed, 71 insertions(+), 73 deletions(-)
> 
> diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c
> index b0ff6153be6232c5df27a64ac6e271a546cfe6ce..568779d5a0efa4e6891820a0bbb87d3fd9f65721 100644
> --- a/net/core/secure_seq.c
> +++ b/net/core/secure_seq.c
> @@ -71,7 +71,7 @@ u32 secure_tcpv6_ts_off(const struct net *net,
>   	return siphash(&combined, offsetofend(typeof(combined), daddr),
>   		       &ts_secret);
>   }
> -EXPORT_SYMBOL(secure_tcpv6_ts_off);
> +EXPORT_IPV6_MOD(secure_tcpv6_ts_off);
>   

[..]

> -EXPORT_SYMBOL_GPL(tcp_set_keepalive);
> +EXPORT_IPV6_MOD_GPL(tcp_set_keepalive);
>   
>   static void tcp_keepalive_timer(struct timer_list *t)
>   {

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>