netdev - Re: [PATCH v2 net-next 4/4] udp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3135409e-d92a-41d0-a865-e7db0c6e7ce4@intel.com>
Date: Thu, 13 Feb 2025 08:28:11 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, Simon Horman <horms@...nel.org>, "Willem de
 Bruijn" <willemb@...gle.com>, Sabrina Dubroca <sd@...asysnail.net>, "Neal
 Cardwell" <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	<eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 4/4] udp: use EXPORT_IPV6_MOD[_GPL]()



On 2/12/2025 2:24 PM, Eric Dumazet wrote:
> Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
> to be exported unless CONFIG_IPV6=m
> 
> udp_table is no longer used from any modules, and does not
> need to be exported anyway.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>   net/ipv4/udp.c | 63 +++++++++++++++++++++++++-------------------------
>   1 file changed, 31 insertions(+), 32 deletions(-)
> 
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index a9bb9ce5438eaa9f9ceede1e4ac080dc6ab74588..3485989cd4bdec96e8cb7ecb28b68a25c3444a96 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -121,13 +121,12 @@
>   #endif
>   
>   struct udp_table udp_table __read_mostly;
> -EXPORT_SYMBOL(udp_table);

[...]

> -EXPORT_SYMBOL(udp_seq_stop);
> +EXPORT_IPV6_MOD(udp_seq_stop);
>   
>   /* ------------------------------------------------------------------------ */
>   static void udp4_format_sock(struct sock *sp, struct seq_file *f,
> @@ -3616,7 +3615,7 @@ const struct seq_operations udp_seq_ops = {
>   	.stop		= udp_seq_stop,
>   	.show		= udp4_seq_show,
>   };
> -EXPORT_SYMBOL(udp_seq_ops);
> +EXPORT_IPV6_MOD(udp_seq_ops);
>   
>   static struct udp_seq_afinfo udp4_seq_afinfo = {
>   	.family		= AF_INET,

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>