netdev - Re: [PATCH v1 net-next] checkpatch: Discourage a new use of rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213121846.57655-1-kuniyu@amazon.com>
Date: Thu, 13 Feb 2025 21:18:46 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuniyu@...zon.com>
CC: <apw@...onical.com>, <davem@...emloft.net>, <dwaipayanray1@...il.com>,
	<edumazet@...gle.com>, <horms@...nel.org>, <joe@...ches.com>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <lukas.bulwahn@...il.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v1 net-next] checkpatch: Discourage a new use of rtnl_lock() variants.

From: Kuniyuki Iwashima <kuniyu@...zon.com>
Date: Thu, 13 Feb 2025 21:10:28 +0900
> > Also I'm unsure if the '^\+.*' header is strictly required - it should
> > but some/most existing tests don't use it, do you know why?
> 
> I didn't notice but exactly, the following matches only + line.
> 
>   if ($line =~ /\brtnl_(try)?lock(_interruptible|_killable)?\s*\(\)/) {
> 
> Looks like the '-' diff is filtered, matching '-' doesn't make sense.
> 
> This function looks suspicious ? (maybe wrong, I'm not familiar with perl)

I was wrong, this part did the filtering :)

---8<---
#ignore lines not being added
                next if ($line =~ /^[^\+]/);
---8<---