netdev - Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250213090123.0ca3220f@kernel.org>
Date: Thu, 13 Feb 2025 09:01:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Stanislav Fomichev <stfomichev@...il.com>, davem@...emloft.net,
 netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, willemb@...gle.com,
 shuah@...nel.org, petrm@...dia.com
Subject: Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

On Thu, 13 Feb 2025 11:02:51 -0500 Willem de Bruijn wrote:
> > > +        # Check that at least 90% of the data was sent as LSO packets.
> > > +        # System noise may cause false negatives, it is what it is.
> > > +        total_lso_wire  = len(buf) * 0.90 // cfg.dev["mtu"]
> > > +        total_lso_super = len(buf) * 0.90 // cfg.dev["tso_max_size"]  
> 
> Besides noise this also includes the payload to wire length with headers
> fudge factor, right?

Ah, fair point, up to 5% of header overhead here. I'll add that 
to the comment.