netdev - Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213090745.09033f27@kernel.org>
Date: Thu, 13 Feb 2025 09:07:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 willemb@...gle.com, shuah@...nel.org, petrm@...dia.com
Subject: Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

On Thu, 13 Feb 2025 11:01:33 -0500 Willem de Bruijn wrote:
> Is the special handling of GSO partial needed?
> 
> This test is not trying to test that feature.

If I leave partial enabled and disable tx-udp_tnl-segmentation 
I still get TSO packets in the driver in the vxlan tests.
Not entirely unreasonable since these are the HW features,
and with partial enabled the HW does not do UDP tunnel-aware
segmentation?

> > +def main() -> None:
> > +    with NetDrvEpEnv(__file__, nsim_test=False) as cfg:
> > +        cfg.ethnl = EthtoolFamily()
> > +        cfg.netnl = NetdevFamily()
> > +
> > +        query_nic_features(cfg)
> > +
> > +        tun_info = (
> > +            # name,         ethtool_feature              tun:(type,    args   4/6 only)
> > +            ("",            "tx-tcp6-segmentation",          None),  
> 
> tx-tcp6-segmentation implies v6 only? The catch-all is tcp-segmentation-offload.

oops, if only I had an ipv4 network to test on :)