netdev - Re: [PATCH v10 03/26] cxl: move pci generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214171147.00007e5f@huawei.com>
Date: Fri, 14 Feb 2025 17:11:47 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Alejandro Lucero Palau <alucerop@....com>
CC: Ira Weiny <ira.weiny@...el.com>, <linux-cxl@...r.kernel.org>,
	<netdev@...r.kernel.org>, <dan.j.williams@...el.com>, <edward.cree@....com>,
	<davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<edumazet@...gle.com>, <dave.jiang@...el.com>
Subject: Re: [PATCH v10 03/26] cxl: move pci generic code

On Thu, 6 Feb 2025 17:49:00 +0000
Alejandro Lucero Palau <alucerop@....com> wrote:

> On 2/5/25 21:33, Ira Weiny wrote:
> > alucerop@ wrote:  
> >> From: Alejandro Lucero <alucerop@....com>  
> > [snip]
> >  
> >> diff --git a/include/cxl/pci.h b/include/cxl/pci.h
> >> index ad63560caa2c..e6178aa341b2 100644
> >> --- a/include/cxl/pci.h
> >> +++ b/include/cxl/pci.h
> >> @@ -1,8 +1,21 @@
> >>   /* SPDX-License-Identifier: GPL-2.0-only */
> >>   /* Copyright(c) 2020 Intel Corporation. All rights reserved. */
> >>   
> >> -#ifndef __CXL_ACCEL_PCI_H
> >> -#define __CXL_ACCEL_PCI_H
> >> +#ifndef __LINUX_CXL_PCI_H
> >> +#define __LINUX_CXL_PCI_H  
> > Nit: I'd just use __LINUX_CXL_PCI_H in the previous patch.  
> 
> 
> Dan suggested this change.
Would be odd if he meant in this patch....

Definitely no benefit in doing it here rather that when you
create the file in patch 1 that I can see.

J

> 
> 
> > Ira
> >
> > [snip]  
> 
>