netdev - Re: [PATCH net-next] net: skb: do not assume that ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250214165755.1f1ecc36@kernel.org>
Date: Fri, 14 Feb 2025 16:57:55 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: skb: do not assume that ktime_t is equal
 to s64

On Thu, 13 Feb 2025 13:16:58 +0300 Dmitry Antipov wrote:
> In 'skb_get_timestamp()', do not assume that 'tstamp' of 'struct
> sk_buff' (which is 'ktime_t') may be implicitly converted to 's64'
> (which is expected by 'ns_to_kernel_old_timeval()') but use
> the convenient 'ktime_to_ns()' instead. Compile tested only.

Is there a real bug here or you just run a scanner which checks 
if types match? As is the commit message doesn't really explain
what the potential problem is.

Also please run get_maintainer.pl on the patch, you missed two people.
-- 
pw-bot: cr