netdev - Re: [RFC PATCH] netlink: Unset cb_running when terminating dump on release.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214170631.6badcc24@kernel.org>
Date: Fri, 14 Feb 2025 17:06:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Siddh Raman Pant <siddh.raman.pant@...cle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev
 <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] netlink: Unset cb_running when terminating dump on
 release.

On Fri, 14 Feb 2025 12:28:49 +0530 Siddh Raman Pant wrote:
> When we terminated the dump, the callback isn't running, so cb_running
> should be set to false to be logically consistent.
> 
> Fixes: 1904fb9ebf91 ("netlink: terminate outstanding dump on socket close")
> Fixes: 16b304f3404f ("netlink: Eliminate kmalloc in netlink dump operation.")
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@...cle.com>
> ---
> I found this by inspection and was thinking why it isn't being done. So
> I thought I should ask by sending a patch.

I only see uses in places called by user space. So code which can't 
be run once we're in release.

You can send as a cleanup, if you want, but with more analysis in
the commit msg, and no fixes tags.