netdev - RE: [PATCH net-next] net: xilinx: axienet: Implement BQL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL3PR12MB6571A18DA9E284A301FF70FAC9F92@BL3PR12MB6571.namprd12.prod.outlook.com>
Date: Sat, 15 Feb 2025 11:32:32 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Sean Anderson <sean.anderson@...ux.dev>, "Pandey, Radhey Shyam"
	<radhey.shyam.pandey@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
	<kuba@...nel.org>, "Simek, Michal" <michal.simek@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>
Subject: RE: [PATCH net-next] net: xilinx: axienet: Implement BQL



> -----Original Message-----
> From: Sean Anderson <sean.anderson@...ux.dev>
> Sent: Saturday, February 15, 2025 2:43 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>;
> netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; Paolo Abeni <pabeni@...hat.com>; David S .
> Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Simek, Michal
> <michal.simek@....com>; linux-arm-kernel@...ts.infradead.org; Eric Dumazet
> <edumazet@...gle.com>; Andrew Lunn <andrew+netdev@...n.ch>; Sean
> Anderson <sean.anderson@...ux.dev>
> Subject: [PATCH net-next] net: xilinx: axienet: Implement BQL
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> Implement byte queue limits to allow queueing disciplines to account for packets
> enqueued in the ring buffers but not yet transmitted.
> 

Could you please check if BQL can be implemented for DMAengine flow?

> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> ---
> 
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 0673b2694e4c..7406e00de0fb 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1002,6 +1002,7 @@ static int axienet_tx_poll(struct napi_struct *napi, int
> budget)
>                                         &size, budget);
> 
>         if (packets) {
> +               netdev_completed_queue(ndev, packets, size);
>                 u64_stats_update_begin(&lp->tx_stat_sync);
>                 u64_stats_add(&lp->tx_packets, packets);
>                 u64_stats_add(&lp->tx_bytes, size); @@ -1125,6 +1126,7 @@
> axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>         if (++new_tail_ptr >= lp->tx_bd_num)
>                 new_tail_ptr = 0;
>         WRITE_ONCE(lp->tx_bd_tail, new_tail_ptr);
> +       netdev_sent_queue(ndev, skb->len);
> 
>         /* Start the transfer */
>         axienet_dma_out_addr(lp, XAXIDMA_TX_TDESC_OFFSET, tail_p); @@ -
> 1751,6 +1753,7 @@ static int axienet_stop(struct net_device *ndev)
>                 dma_release_channel(lp->tx_chan);
>         }
> 
> +       netdev_reset_queue(ndev);
>         axienet_iow(lp, XAE_IE_OFFSET, 0);
> 
>         if (lp->eth_irq > 0)
> @@ -2676,6 +2679,7 @@ static void axienet_dma_err_handler(struct work_struct
> *work)
>                            ~(XAE_OPTION_TXEN | XAE_OPTION_RXEN));
> 
>         axienet_dma_stop(lp);
> +       netdev_reset_queue(ndev);
> 
>         for (i = 0; i < lp->tx_bd_num; i++) {
>                 cur_p = &lp->tx_bd_v[i];
> --
> 2.35.1.1320.gc452695387.dirty
>