netdev - Re: [PATCH bpf-next v2 2/3] bpf: support TCP_RTO_MAX_MS for bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250217212854.62301-1-kuniyu@amazon.com>
Date: Mon, 17 Feb 2025 13:28:54 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kerneljasonxing@...il.com>
CC: <andrii@...nel.org>, <ast@...nel.org>, <bpf@...r.kernel.org>,
	<daniel@...earbox.net>, <davem@...emloft.net>, <dsahern@...nel.org>,
	<eddyz87@...il.com>, <edumazet@...gle.com>, <haoluo@...gle.com>,
	<john.fastabend@...il.com>, <jolsa@...nel.org>, <kpsingh@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <martin.lau@...ux.dev>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <sdf@...ichev.me>,
	<shuah@...nel.org>, <song@...nel.org>, <ykolal@...com>,
	<yonghong.song@...ux.dev>
Subject: Re: [PATCH bpf-next v2 2/3] bpf: support TCP_RTO_MAX_MS for bpf_setsockopt

From: Jason Xing <kerneljasonxing@...il.com>
Date: Mon, 17 Feb 2025 11:42:44 +0800
> Some applications don't want to wait for too long because the
> time of retransmission increases exponentially and can reach more
> than 10 seconds, for example. Eric implements the core logic
> on supporting rto max feature in the stack previously. Based on that,
> we can support it for BPF use.
> 
> This patch reuses the same logic of TCP_RTO_MAX_MS in do_tcp_setsockopt()
> and do_tcp_getsockopt(). BPF program can call bpf_{set/get}sockopt()
> to set/get the maximum value of RTO.
> 
> It would be good if a BPF program sets max value of RTO before
> transmission as we can see in the later patch (selftests).
> 
> Signed-off-by: Jason Xing <kerneljasonxing@...il.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>