netdev - RE: [PATCH net-next v7 0/4] Support PTP clock for Wangxun NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <050201db80dd$f4b45bb0$de1d1310$@trustnetic.com>
Date: Mon, 17 Feb 2025 09:47:51 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Jakub Kicinski'" <kuba@...nel.org>
Cc: <andrew+netdev@...n.ch>,
	<davem@...emloft.net>,
	<edumazet@...gle.com>,
	<pabeni@...hat.com>,
	<richardcochran@...il.com>,
	<linux@...linux.org.uk>,
	<horms@...nel.org>,
	<jacob.e.keller@...el.com>,
	<netdev@...r.kernel.org>,
	<vadim.fedorenko@...ux.dev>,
	<mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v7 0/4] Support PTP clock for Wangxun NICs

On Sat, Feb 15, 2025 8:52 AM, Jakub Kicinski wrote:
> On Thu, 13 Feb 2025 16:30:37 +0800 Jiawen Wu wrote:
> > Implement support for PTP clock on Wangxun NICs.
> 
> Please run:
> 
> ./scripts/kernel-doc -none -Wall drivers/net/ethernet/wangxun/*/*
> 
> Existing errors are fine, but you shouldn't be adding new ones.
> You're missing documentation for return values for a lot of functions.
> 
> Note that adding kdoc is not required, you can just remove it where
> it doesn't add value. But if you add kdoc comments they need to be
> fully specified.

OK, I'll fix it in the V8 patch set.
So what is the conclusion about the "work" item. Should I revert it to V6?